You Got A Question? Ask    GNOME Community!


Shell Is Now Managing Window Menus | Sweet!

Update: Jasper St. Pierre

I want to point out that this was simply done for technical cleanup reasons as part of Wayland. We went from a GTK+ menu with some entries in it to a gnome-shell menu with the same entries. So it’s not a giant change.

The design team wasn’t involved in this bug. If I talked to them, maybe we could consolidate some of the menus.

shell-window-menus
GTK Window Menus are now replaced by Shell Menus!
The UI Shell file is at js/ui/WindowMenu.js

That change was made a few hours ago from Jasper St. Pierre (Shell commit, Mutter commit). Of course it will involve some more work on GTK+ itself and CSD menus.

Implement window menus in gnome-shell

This is something we’ve wanted to do for a long time for code clarity reasons and design reasons. Wayland really gives us the first opportunity to do it.


Convert window menus to use a compositor implementation.

Window menus being GTK+ widgets has always been frustrating to deal with. Under Wayland, GTK+ is using the X11 backend, so the menus there pop up in the wrong place, don’t take a grab, and are unstyled.

Given that we have a sophisticated menu system as a replacement in gnome-shell, we can port over to using that instead.

This does remove window menus for the default plugin, but given how we’ve been steadily removing features for that the entire time, I’m OK with this tradeoff.

This removes the bare minimum of unused code I could find. There’s probably still a lot of code left working around GTK+’s grab tracking that could go away entirely. A full cleanup should be
done later.

#726352

Obviously it will not work on applications that have custom header bars (like Chromium, if you have disabled system title bar and borders). At the moment isn’t either working with CSDs, but this is something that will be done soon!


Is it just a menu?

You can tell that is just another menu, but in reality is a new container that we can easily extend. For example we could add the application menu there as well, or have some custom events etc.. So it is pretty cool! It also looks nice too!


 
  We can't watch comments unless G+ provides an API or if you send a notification, e.g +World Of Gnome
     Sometimes is better to place your questions on GNOME Community